Fix reporting when skipping extensions #3254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lists ext and ext_instances become out of sync when extensions are skipped. Hence use ext_instances as the true source for reporting Also fix the documentation of skip_extensions and add verbose reporting to stdout
Flamefire
force-pushed
the
fix_ext_skipping
branch
from
c55a115
to
cd49c19
Compare
|
Changes look good, but I'm wondering if we can make sure the tests trip over the misreporting? |
|
Not without actually running a real build and intercepting the output. Sounds like a bit of overkill for me. |
|
@Flamefire We try to get all bug fixes covered by the tests, to avoid re-introducing the issue later. Done in Flamefire#1 |
|
Ah that easy, thanks! |
minor fix + enhanced test for skipped extensions
boegel
approved these changes
Mar 25, 2020
|
@Flamefire I think the issue was that the Travis GitHub App was not registered yet, which I've fixed just now. We shouldn't be hitting rate limits at all I think... |
|
60/hour isn't much. In the mentioned PR I use an endpoint that isn't even rate limitted hence should work better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lists ext and ext_instances become out of sync when extensions are skipped.
Hence use ext_instances as the true source for reporting
Also fix the documentation of skip_extensions and add verbose reporting to stdout
Fixes #3253